learnyouahaskell.github.io icon indicating copy to clipboard operation
learnyouahaskell.github.io copied to clipboard

Published 20 hours ago • verified publisher icon learnyouahaskell

Replace Comments about BMI

Open andrewthad opened this issue 3 years ago • 3 comments
trafficstars

The syntax-in-functions page includes a BMI example that may benefit from being rewritten. The two options I'm aware of would be:

  • Keeping using BMI as the example, but change the messages for different categories
  • Change the example to something else that uses division, perhaps calculating speed from distance and time, and then it would be possible to provide silly messages that aren't about a sensitive issue.

I prefer the second option because I think it would just be best to avoid discussing BMI. I am happy to put together a PR if the maintainer agrees.

andrewthad avatar Feb 10 '22 21:02 andrewthad

@andrewthad Thanks for pointing this out! Yes, please feel free to fork and submit a PR. Pull requests are always welcome. ( and preferred 😇 )

smith558 avatar Feb 12 '22 13:02 smith558

one case here: https://learnyouahaskell.github.io/syntax-in-functions.html#let-it-be

image

smith558 avatar Feb 18 '22 19:02 smith558

@andrewthad you mentioned you were interested in submitting a PR. I think it would be a great improvement. I just bumped into another SO question about this terrible example.

I'm leaning towards your option 2 (do away with BMI altogether).

ulysses4ever avatar Jul 11 '22 15:07 ulysses4ever