lean4 icon indicating copy to clipboard operation
lean4 copied to clipboard

Use `Bool.asProp` for coercions

Open gebner opened this issue 2 years ago • 4 comments
trafficstars

Fixes #2043.

gebner avatar Jan 24 '23 05:01 gebner

Required mathlib changes are manageable, as expected: https://github.com/leanprover/std4/compare/pr2060?expand=1 https://github.com/leanprover-community/mathlib4/compare/pr2060?expand=1

gebner avatar Jan 24 '23 05:01 gebner

!bench

gebner avatar Jan 24 '23 05:01 gebner

Here are the benchmark results for commit 8b214965654397d4f62d2b6f62ebd49c0a8c127d. There were significant changes against commit 345aa6f835aa6ab1c31180281b18e3b80b7d173a:

  Benchmark          Metric         Change
  ====================================================
+ qsort              task-clock      -1.4%   (-17.5 σ)
+ qsort              wall-clock      -1.4%   (-17.6 σ)
+ stdlib             instructions    -2.1% (-2365.0 σ)
- stdlib             maxrss           1.1%    (19.7 σ)
+ stdlib             task-clock      -2.5%   (-38.5 σ)
+ stdlib             wall-clock      -2.9%  (-392.4 σ)
- stdlib size        bytes .olean     1.7%
- workspaceSymbols   maxrss           1.1%    (15.4 σ)
+ workspaceSymbols   task-clock      -2.1%   (-10.0 σ)
+ workspaceSymbols   wall-clock      -2.1%   (-10.1 σ)

leanprover-bot avatar Jan 24 '23 06:01 leanprover-bot

I really like this but please post something on Zulip when merging since this looks like some significant update changes. A few quick hints might help too. Please remember that mathlib is not the only thing downstream 😄

fgdorais avatar Feb 03 '23 07:02 fgdorais