mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Fin/Parity): add `Fin.even_iff`

Open urkud opened this issue 1 year ago • 1 comments

Motivated by this Zulip question.


  • [ ] depends on: #8974

Open in Gitpod

urkud avatar Dec 10 '23 22:12 urkud

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#8974~~ By Dependent Issues (🤖). Happy coding!

PR summary 2c581bd163

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Data.Fin.Parity 471

Declarations diff

+ add_one_lt_of_even + even_iff + even_iff_imp + even_iff_of_even + even_of_odd + even_of_val + odd_iff + odd_iff_imp + odd_iff_of_even + odd_of_odd + odd_of_val + one_lt_of_ne_zero_of_even + val_add_eq_of_add_lt

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

github-actions[bot] avatar Jun 08 '24 21:06 github-actions[bot]

@urkud are you going to continue with this pull request? If not, can I continue with it?

IvanRenison avatar Nov 01 '24 14:11 IvanRenison

Feel free to take over this PR. Thanks!

urkud avatar Nov 01 '24 14:11 urkud

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

github-actions[bot] avatar Nov 06 '24 21:11 github-actions[bot]

bors merge

kim-em avatar Nov 06 '24 23:11 kim-em

For some reason the commit has the "Co-authored-by" two times

IvanRenison avatar Nov 06 '24 23:11 IvanRenison

Build failed:

mathlib-bors[bot] avatar Nov 06 '24 23:11 mathlib-bors[bot]

bors d=IvanRenison

bryangingechen avatar Nov 07 '24 03:11 bryangingechen

:v: IvanRenison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Nov 07 '24 03:11 mathlib-bors[bot]

Please merge master, fix the breakage and then merge with bors d+ when done, thanks!

bryangingechen avatar Nov 07 '24 03:11 bryangingechen

Apologies for the late review, I forgot to send it earlier

Command-Master avatar Nov 07 '24 10:11 Command-Master

Thanks for the review @Command-Master, I was very surprised that the first two reviewers didn't find anything. I was very lucky that the build failed

IvanRenison avatar Nov 07 '24 18:11 IvanRenison

bors r+

IvanRenison avatar Nov 11 '24 12:11 IvanRenison

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Nov 11 '24 13:11 mathlib-bors[bot]