mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Data/Nat/Choose): add `Choose.lucas`

Open grhkm21 opened this issue 1 year ago • 2 comments
trafficstars

TODO: Name the stuff properly and finish the proofs. Suggestions on naming would be greatly appreciated.

grhkm21 avatar Nov 24 '23 14:11 grhkm21

Please fix the long lines the linter is complaining about.

kim-em avatar May 06 '24 05:05 kim-em

(You can change the label back to awaiting-review when you're ready!)

kim-em avatar May 06 '24 05:05 kim-em

Sorry for the long wait, exams :( Fixed the issues above!

grhkm21 avatar May 24 '24 16:05 grhkm21

PR summary e82d217ef5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Data.Nat.Choose.Lucas 1107

Declarations diff

+ add_pow_eq_add_pow_mod_mul_pow_add_pow_div + choose_modEq_choose_mod_mul_choose_div + choose_modEq_choose_mod_mul_choose_div_nat + choose_modEq_choose_mul_prod_range_choose + choose_modEq_prod_range_choose + choose_modEq_prod_range_choose_nat + lucas_theorem + lucas_theorem_nat + sub_pow_eq_sub_pow_mod_mul_pow_sub_pow_div

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

github-actions[bot] avatar Jun 15 '24 22:06 github-actions[bot]

I have reverted the ite -> if-then-else changes (TIL about git reset --patch). Hope it's okay now :D

grhkm21 avatar Jun 18 '24 19:06 grhkm21

Okay I should have cleaned up stuff. Also I realised a proof didn't even compile, so I fixed that (it depended on the prod_ite_eq_iff thing

grhkm21 avatar Jun 20 '24 02:06 grhkm21

Sorry, my browser automatically corrects wikipedia links to wikiwand.

grhkm21 avatar Jun 26 '24 16:06 grhkm21

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Jun 29 '24 19:06 github-actions[bot]

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

github-actions[bot] avatar Jun 29 '24 19:06 github-actions[bot]

I take it that the TODO in the PR commit message (i.e. the top post above) no longer applies? If so, please update it.

jcommelin avatar Jul 04 '24 06:07 jcommelin

@jcommelin Done, sorry about that

grhkm21 avatar Jul 04 '24 15:07 grhkm21

bors d+

kim-em avatar Jul 15 '24 16:07 kim-em

:v: grhkm21 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Jul 15 '24 16:07 mathlib-bors[bot]

@b-mehta do you mind reviewing the latest (two) commits? I added the nat versions as suggested

grhkm21 avatar Jul 19 '24 18:07 grhkm21

Looks like you got hit by the new linter:

warning: ././././Mathlib/Data/Nat/Choose/Lucas.lean:99:0: unclosed sections or namespaces; expected: '

end Choose'

Ruben-VandeVelde avatar Jul 20 '24 09:07 Ruben-VandeVelde

Thanks a lot for this contribution! Let's just merge this. Follow-up versions can be done in a follow-up PR.

bors merge

jcommelin avatar Jul 23 '24 13:07 jcommelin

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 23 '24 14:07 mathlib-bors[bot]