mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: port apply_fun

Open kim-em opened this issue 3 years ago • 1 comments
trafficstars

This will need minor additions once the tactic mono is ported, and some additional testing after Logic.Equiv.Basic and Order.Hom.Basic are ported.

kim-em avatar Oct 17 '22 00:10 kim-em

Did you check that mathlib actually uses the part of apply_fun that uses mono? I think I wrote this because it seemed like a nice idea but I would be surprised to learn it is used a lot.

PatrickMassot avatar Oct 18 '22 07:10 PatrickMassot

Did you check that mathlib actually uses the part of apply_fun that uses mono? I think I wrote this because it seemed like a nice idea but I would be surprised to learn it is used a lot.

Yes, the build fails without it, perhaps just at category_theory/subobject/basic.lean line 533.

kim-em avatar Oct 19 '22 03:10 kim-em

bors merge

digama0 avatar Nov 07 '22 21:11 digama0

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Nov 07 '22 21:11 bors[bot]