mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: generalize_proofs tactic

Open alexjbest opened this issue 3 years ago • 1 comments
trafficstars

alexjbest avatar Sep 30 '22 00:09 alexjbest

There are still a couple of things to do to please the linters, but I'd be glad to receive feedback on this PR at this stage

alexjbest avatar Oct 07 '22 00:10 alexjbest

There are still some TODO items for this tactic remaining, but I think it's fine to merge now.

  • It does not handle hypotheses that depend on binders correctly, it gives a result is not type correct error. (A commented-out test displays this issue.) It should forall-quantify the hypotheses to lift them out of whatever context they appear in.
  • It should reuse hypotheses in the context when available rather than introducing a new hypothesis.

bors merge

digama0 avatar Nov 07 '22 20:11 digama0

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Nov 07 '22 21:11 bors[bot]