mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: port fin_cases

Open kim-em opened this issue 3 years ago • 5 comments
trafficstars

This is a port of fin_cases. It doesn't yet support the with or using clauses from mathlib3.

I could remove the dependence on #433, but would have to (temporarily) remove all the tests to do so.

  • depends on: #433

kim-em avatar Sep 23 '22 02:09 kim-em

I'm not enthused about this implementation, it has a lot of potential failure modes, but since it's not passing all the tests or implementing all the options we'll need to extend it later anyway, and this is good enough for now.

bors r+

digama0 avatar Oct 18 '22 00:10 digama0

Build failed:

bors[bot] avatar Oct 18 '22 00:10 bors[bot]

The implementation is pretty much isomorphic to the one in mathlib3, so I'll blame the author of that. (Err... sorry.)

After I merge master it is all failing, with metavariables in the declarations, and I'm not immediately seeing why.

kim-em avatar Oct 18 '22 05:10 kim-em

Ugh, voodoo changing a 3 to a 2 fixes the main problem.

Currently, if you call fin_cases h on a bad hypotheses that it can't handle, it just deletes the goal and reports success. Not cool...

kim-em avatar Oct 18 '22 05:10 kim-em

Okay, at least superficially fixed that, now we don't catch the error if cases outright fails.

kim-em avatar Oct 18 '22 06:10 kim-em

bors merge

kim-em avatar Oct 20 '22 01:10 kim-em

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Oct 20 '22 01:10 bors[bot]