mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore: port lint-style.py from mathlib

Open kim-em opened this issue 3 years ago • 2 comments
trafficstars

Some of these are no longer relevant, but I want to see what works before cleaning up.

kim-em avatar Jul 26 '22 23:07 kim-em

This runs, and respects the content of scripts/style-extensions.txt.

I propose that actually fixing style exceptions, and removing the style tests which are not relevant for mathlib4 (e.g. I think the curly brace linter), happens in a subsequent PR.

kim-em avatar Jul 27 '22 00:07 kim-em

Obviously this should eventually be rewritten in Lean, but we can use the python script for now.

Before merging, we should remove the curly braces linter though because it has lots of false positives.

gebner avatar Aug 18 '22 18:08 gebner

I've removed the curly brace linter, the indentation linter and the unfreeze_local_instance linter, as they are not fit for purpose for Lean4. I've also added a TODO about re-implementing in Lean4!

kim-em avatar Sep 13 '22 23:09 kim-em

Great, all exceptions look legit now!

bors merge

gebner avatar Sep 15 '22 12:09 gebner

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Sep 15 '22 12:09 bors[bot]