mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Order/Hom/Basic): `WithBot (Fin n) ≃o Fin (n + 1)`

Open vihdzp opened this issue 1 year ago • 3 comments


Open in Gitpod

vihdzp avatar Oct 25 '24 01:10 vihdzp

PR summary c5064a0eba

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ WithBot.orderIsoFin + WithTop.orderIsoFin

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Oct 25 '24 01:10 github-actions[bot]

Nice! These proofs are way cleaner.

vihdzp avatar Oct 25 '24 05:10 vihdzp

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

github-actions[bot] avatar Oct 26 '24 08:10 github-actions[bot]

This pull request has conflicts, please merge master and resolve them.

I don't need this anymore; if someone else needs this they should probably do it the proper way by using the existing equiv.

vihdzp avatar Oct 15 '25 00:10 vihdzp