mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Analysis/Normed/Group/SeparationQuotient): add normed lifts and `mk`

Open yoh-tanimoto opened this issue 1 year ago • 1 comments

Define the mk and lifts of normed spaces and normed groups by the inseparable setoid as NormedAddGroupHom, CLM, etc.

Motivation: In the GNS representation, operators in the original C^*-algebra are represented as bounded linear operators.

This PR splits from #16707.

yoh-tanimoto avatar Oct 24 '24 14:10 yoh-tanimoto

messageFile.md

github-actions[bot] avatar Oct 24 '24 14:10 github-actions[bot]

The import increases look quite bad. Do you think you can do something about them?

YaelDillies avatar Jan 20 '25 17:01 YaelDillies

I'm not sure, as for Mathlib.Topology.Algebra.SeparationQuotient.Basic, I added Mathlib.Topology.Algebra.ContinuousMonoidHom which is necessary because I define liftContinuousMonoidHom. I don't understand Mathlib.Analysis.Normed.Group.Hom, I don't add any import?

yoh-tanimoto avatar Jan 29 '25 01:01 yoh-tanimoto

messageFile.md

github-actions[bot] avatar Jan 29 '25 02:01 github-actions[bot]

Can you merge master to fix the bot?

YaelDillies avatar Jan 29 '25 07:01 YaelDillies

PR summary 2ae70a42c6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Algebra.SeparationQuotient.Hom (new file) 1121
Mathlib.Analysis.Normed.Group.SeparationQuotient (new file) 1268

Declarations diff

+ apply_eq_apply_of_inseparable + instance : ContinuousMapClass (NormedAddGroupHom V₁ V₂) V₁ V₂ + liftCLM + liftCLM_mk + liftContinuousCommMonoidHom_mk + liftContinuousMonoidHom + liftNormedAddGroupHom + liftNormedAddGroupHomEquiv + liftNormedAddGroupHom_normNoninc + liftNormedAddGroupHom_norm_le + nhds_mk + norm_liftNormedAddGroupHom_apply_le + norm_liftNormedAddGroupHom_le + norm_normedMk_eq_one + norm_normedMk_le + normedMk + normedMk_eq_zero_iff + ofClass

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

github-actions[bot] avatar Jan 29 '25 10:01 github-actions[bot]

for Mathlib.Topology.Algebra.SeparationQuotient.Basic, I added Mathlib.Topology.Algebra.ContinuousMonoidHom which is necessary because I define liftContinuousMonoidHom

Can you maybe move liftContinuousMonoidHom to a new file Mathlib.Topology.Algebra.SeparationQuotient.Hom? The import increases are currently unacceptably large

YaelDillies avatar Jan 29 '25 11:01 YaelDillies

Thanks, I splitted the file and now it seems ok?

yoh-tanimoto avatar Jan 30 '25 00:01 yoh-tanimoto

LGTM too, thanks!

bors d+

j-loreaux avatar Feb 05 '25 17:02 j-loreaux

:v: yoh-tanimoto can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Feb 05 '25 17:02 mathlib-bors[bot]

thanks for your reviews!

bors r+

yoh-tanimoto avatar Feb 05 '25 23:02 yoh-tanimoto

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Feb 05 '25 23:02 mathlib-bors[bot]