mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore (Algebra.Order.Field.Defs): split off results about unbundled ordered algebra

Open mattrobball opened this issue 1 year ago • 4 comments

We should be able to use these results about unbundled ordered algebra without importing the heavy machinery of the bundled typeclasses.


  • [ ] depends on: #14393

Open in Gitpod

mattrobball avatar Jul 05 '24 14:07 mattrobball

PR summary 5c6bd694ee

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Field.Defs 213 212 -1 (-0.47%)
Import changes for all files
Files Import difference
Too many changes (2641)!

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

github-actions[bot] avatar Jul 05 '24 14:07 github-actions[bot]

!bench

mattrobball avatar Jul 05 '24 14:07 mattrobball

Here are the benchmark results for commit e52dca80ba64e35bbd376e8245cc346113182975. There were significant changes against commit 17a95d6c8cfe5a6dec779187375268505245c934:

  Benchmark                                      Metric         Change
  ====================================================================
- ~Mathlib.Algebra.Order.Field.Basic             instructions    22.2%
+ ~Mathlib.Algebra.Order.Group.Defs              instructions   -78.6%
+ ~Mathlib.Algebra.Order.Ring.Defs               instructions   -79.1%
+ ~Mathlib.NumberTheory.NumberField.Embeddings   instructions    -9.2%

leanprover-bot avatar Jul 05 '24 15:07 leanprover-bot

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#14393~~ By Dependent Issues (🤖). Happy coding!

bors merge

kim-em avatar Jul 17 '24 16:07 kim-em

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 17 '24 18:07 mathlib-bors[bot]