mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore (Algebra.Order.Nonneg.Ring): split into unbundled and bundled ordered algebra files

Open mattrobball opened this issue 1 year ago • 4 comments

We split Algebra.Order.Nonneg.Ring into Algebra.Order.Nonneg.Ring which uses unbundled ordered algebra typeclasses, eg CovariantClass, and Algebra.Order.Nonneg.OrderedRing which uses bundled class, eg OrderedAddComm. Using this we can avoid importing bundled ordered algebra classes until later downstream.


  • [x] depends on: #14371

Open in Gitpod

mattrobball avatar Jul 02 '24 22:07 mattrobball

!bench

mattrobball avatar Jul 02 '24 22:07 mattrobball

PR summary b40fb44fdd

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Order.Nonneg.Ring 435 430 -5 (-1.15%)
Import changes for all files
Files Import difference
Too many changes (2428)!

Declarations diff

+ addCommMonoid + addMonoid + natCast + pow_nonneg

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

github-actions[bot] avatar Jul 02 '24 22:07 github-actions[bot]

Here are the benchmark results for commit d7426a830e3b8d3d17db817530673803abcb0f8f.Found no runs to compare against.

leanprover-bot avatar Jul 02 '24 23:07 leanprover-bot

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#14371~~ By Dependent Issues (🤖). Happy coding!

bors merge

kim-em avatar Jul 15 '24 17:07 kim-em

bors failed, probably because of this file. Removing from the queue, delegating, and merging master. bors r- bors d+

urkud avatar Jul 15 '24 18:07 urkud

:v: mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Jul 15 '24 18:07 mathlib-bors[bot]

Canceled.

mathlib-bors[bot] avatar Jul 15 '24 18:07 mathlib-bors[bot]

bors merge

mattrobball avatar Jul 15 '24 20:07 mattrobball

Build failed (retrying...):

mathlib-bors[bot] avatar Jul 15 '24 21:07 mathlib-bors[bot]

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 16 '24 00:07 mathlib-bors[bot]