mathlib4
mathlib4 copied to clipboard
chore (Algebra.Order.Nonneg.Ring): split into unbundled and bundled ordered algebra files
We split Algebra.Order.Nonneg.Ring into Algebra.Order.Nonneg.Ring which uses unbundled ordered algebra typeclasses, eg CovariantClass, and Algebra.Order.Nonneg.OrderedRing which uses bundled class, eg OrderedAddComm. Using this we can avoid importing bundled ordered algebra classes until later downstream.
- [x] depends on: #14371
!bench
PR summary b40fb44fdd
Import changes for modified files
Dependency changes
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Nonneg.Ring | 435 | 430 | -5 (-1.15%) |
Import changes for all files
| Files | Import difference |
|---|---|
| Too many changes (2428)! |
Declarations diff
+ addCommMonoid
+ addMonoid
+ natCast
+ pow_nonneg
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
Here are the benchmark results for commit d7426a830e3b8d3d17db817530673803abcb0f8f.Found no runs to compare against.
This PR/issue depends on:
- ~~leanprover-community/mathlib4#14371~~ By Dependent Issues (🤖). Happy coding!
bors merge
bors failed, probably because of this file. Removing from the queue, delegating, and merging master.
bors r-
bors d+
:v: mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.
Canceled.
bors merge