mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

Feat(AlgebraicGeometry/FromSpecStalk): Given a scheme `X` and a point `x : X`, the canonical scheme morphism from `Spec(O_x)` to `X`.

Open FMLJohn opened this issue 1 year ago • 4 comments

In this pull request, we define: Given a scheme X and a point x : X.carrier, AlgebraicGeometry.Scheme.fromSpecStalk X x is the canonical scheme morphism from Spec(O_x) to X.

This is helpful for constructing the canonical map from the spectrum of the residue field of a point to the original scheme.

FMLJohn avatar Jun 16 '24 21:06 FMLJohn

PR summary c53d86ee9d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Stalk 1536

Declarations diff

+ IsAffineOpen.fromSpecStalk + IsAffineOpen.fromSpecStalk_eq + IsAffineOpen.fromSpecStalk_eq_fromSpecStalk + Scheme.fromSpecStalk + Scheme.isoSpec_hom_naturality + Scheme.isoSpec_inv_naturality + map_fromSpec

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jun 16 '24 21:06 github-actions[bot]

This looks fine to me, I've left some comments which are mostly about docstrings.

kbuzzard avatar Jul 04 '24 14:07 kbuzzard

Thanks! maintainer merge

erdOne avatar Jul 05 '24 19:07 erdOne

🚀 Pull request has been placed on the maintainer queue by erdOne.

github-actions[bot] avatar Jul 05 '24 19:07 github-actions[bot]

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 06 '24 05:07 mathlib-bors[bot]