mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: multiple universe polymorphism for the equational criterion for flatness

Open trivial1711 opened this issue 1 year ago • 1 comments

Algebra/Module/FinitePresentation.lean is now fully universe polymorphic. This had the side effect of somehow breaking RingTheory/Flat/EquationalCriterion.lean, even though I didn't even touch that file. Should I even be trying to do this?


  • [ ] depends on: #12666 Open in Gitpod

trivial1711 avatar May 23 '24 19:05 trivial1711

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#12666~~ By Dependent Issues (🤖). Happy coding!

PR summary c2377b1395

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.TensorProduct.Vanishing 1095 1096 +1 (+0.09%)

Declarations diff

+ VanishesTrivially.equiv.{uι'} + VanishesTrivially.universe_shift

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jun 12 '24 23:06 github-actions[bot]

I'm trying to use the equational criterion in the proof of https://stacks.math.columbia.edu/tag/00NZ, but it doesn't apply directly due to universe non-polymorphism. I'd like to take over this PR if no one objects. (Or maybe it's better to open a new PR; will post here.)

alreadydone avatar Jan 02 '25 23:01 alreadydone

I'm trying to use the equational criterion in the proof of https://stacks.math.columbia.edu/tag/00NZ, but it doesn't apply directly due to universe non-polymorphism. I'd like to take over this PR if no one objects. (Or maybe it's better to open a new PR; will post here.)

Please do.

trivial1711 avatar Jan 03 '25 03:01 trivial1711

Thanks! Opened #20452.

alreadydone avatar Jan 03 '25 18:01 alreadydone