mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(NumberTheory/SmoothNumbers): multiplicativity

Open rwst opened this issue 1 year ago • 7 comments
trafficstars

Prove that the product of two n-smooth numbers is an n-smooth number. Uses two helper lemmas.


Open in Gitpod

rwst avatar May 22 '24 15:05 rwst

Thanks for the improvements. I'm learning.

rwst avatar May 24 '24 10:05 rwst

Here it is!

rwst avatar May 24 '24 14:05 rwst

LGTM

Rida-Hamadani avatar May 24 '24 16:05 Rida-Hamadani

It's great to see the informal reviewing process that already happened, thanks a lot! In order for this PR to be merged, somebody with review powers still needs to give explicit approval. Let me label this PR with awaiting-review so it shows up in the "review queue" where it will be noticed.

grunweg avatar May 24 '24 18:05 grunweg

awaiting-author

grunweg avatar May 24 '24 18:05 grunweg

I would like to deal with the comments in a sequential way, not the least in order to preserve the optimization steps that were done.

rwst avatar May 25 '24 07:05 rwst

@MichaelStollBayreuth I have flagged the PR as WIP, to signal that there is an alternative (and mathematically cleaner) way to do this. I will now open a new branch for that work. Once that is done and merged, this one should be closed.

rwst avatar May 25 '24 08:05 rwst

🚀 Pull request has been placed on the maintainer queue by loefflerd.

github-actions[bot] avatar May 27 '24 07:05 github-actions[bot]

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar May 27 '24 10:05 mathlib-bors[bot]