mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

refactor(LinearAlgebra/BilinearMap): Left composition, bilinear over different rings

Open mans0954 opened this issue 1 year ago • 2 comments
trafficstars

Generalise compl₂ and compl₁₂ for left composition with maps which are linear over different rings in the first and second variable.

Needed for #9334


Open in Gitpod

mans0954 avatar May 19 '24 21:05 mans0954

!bench

mans0954 avatar May 19 '24 22:05 mans0954

Here are the benchmark results for commit d7460b6e3000c2d477b03bc762ac9d28c9ef70f9. There were no significant changes against commit 91e688bd4a6eded8f4e52afa18f98d9c0f5c9475.

leanprover-bot avatar May 19 '24 22:05 leanprover-bot

@eric-wieser do you have a moment to review this PR please? It's quite a small one.

mans0954 avatar Jun 01 '24 06:06 mans0954

Import summary

No significant changes to the import graph

github-actions[bot] avatar Jun 07 '24 06:06 github-actions[bot]

:v: mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Jun 08 '24 18:06 mathlib-bors[bot]

PR summary

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jun 08 '24 20:06 github-actions[bot]

bors r+

mans0954 avatar Jun 08 '24 21:06 mans0954

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jun 08 '24 21:06 mathlib-bors[bot]