mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore: split order synonym instances for GroupWithZero into their own file

Open Ruben-VandeVelde opened this issue 1 year ago • 3 comments
trafficstars

This is consistent with the Group file, and drops the dependency on Mathlib.Order entirely.


  • [x] depends on: #13008
  • [x] depends on: #13033

Open in Gitpod

Ruben-VandeVelde avatar May 17 '24 16:05 Ruben-VandeVelde

Will do.

Ruben-VandeVelde avatar May 20 '24 08:05 Ruben-VandeVelde

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#13008~~
  • ~~leanprover-community/mathlib4#13033~~ By Dependent Issues (🤖). Happy coding!

No declarations were harmed in the making of this PR! 🐙


You can run this locally as follows

## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar May 21 '24 09:05 github-actions[bot]

maintainer merge

(from Yaël earlier; just needed to merge master)

Ruben-VandeVelde avatar May 24 '24 15:05 Ruben-VandeVelde

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

github-actions[bot] avatar May 24 '24 15:05 github-actions[bot]

Thanks a lot for this busywork!

bors merge

kbuzzard avatar May 24 '24 16:05 kbuzzard

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar May 24 '24 17:05 mathlib-bors[bot]