mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

chore: Move `CovariantClass` lemmas

Open YaelDillies opened this issue 1 year ago • 1 comments
trafficstars

The files containing lemmas about the interaction of order in terms of CovariantClass/ContravariantClass and not the bundled compatibility typeclasses were all over the place. This PR puts them all in Algebra.Order.NameOfAlgebraicStructure.Unbundled.


In particular this addresses @semorrison's long time concern that Algebra.Order.Ring.Lemmas is more basic than Algebra.Order.Ring.Defs.

Open in Gitpod

YaelDillies avatar May 16 '24 15:05 YaelDillies

No declarations were harmed in the making of this PR! 🐙


You can run this locally as follows

## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar May 21 '24 09:05 github-actions[bot]

Thanks :tada:

bors merge

jcommelin avatar May 22 '24 12:05 jcommelin

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar May 22 '24 13:05 mathlib-bors[bot]