mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

refactor(CategoryTheory): the structure Functor.FullyFaithful

Open joelriou opened this issue 1 year ago • 1 comments
trafficstars

This PR introduces a structure containing the data involved in a fully faithful functor F, i.e. inverse maps to F.map. (This was suggested by Andrew Yang.)

This should also restore certain definitional properties which may have be lost in #12449 and #12462.

Better names have been given to lemmas IsIso.of_iso and IsIso.of_iso_inv which are now Iso.isIso_hom and Iso.isIso_inv.


Open in Gitpod

joelriou avatar May 15 '24 13:05 joelriou

I moved

This was suggested by @erdOne.

to under --- to avoid Andrew getting pinged on Github whenever someone merges the future commit on master into their branch.

YaelDillies avatar May 15 '24 17:05 YaelDillies

Oops, forgot about this. Thanks a lot! maintainer merge

erdOne avatar May 30 '24 18:05 erdOne

🚀 Pull request has been placed on the maintainer queue by erdOne.

github-actions[bot] avatar May 30 '24 18:05 github-actions[bot]

Thanks!

bors merge

riccardobrasca avatar May 30 '24 18:05 riccardobrasca

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar May 30 '24 19:05 mathlib-bors[bot]