mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(LinearAlgebra/FiniteDimensional): relax condition of results regarding subalgebra = bot

Open acmepjz opened this issue 1 year ago • 2 comments
trafficstars

... from requiring F being a field to F satisfying StrongRankCondition and S being a free F-module. This makes the original statement a special case.

The changed results are: Subalgebra.eq_bot_of_(rank_le|finrank)_one, Subalgebra.[fin]rank_eq_one_iff and Subalgebra.bot_eq_top_iff_[fin]rank_eq_one.

Since the generalized results don't requiring division ring anymore, they are moved to an eariler file LinearAlgebra/Dimension/FreeAndStrongRankCondition.

The proof need to use a new result bijective_algebraMap_of_linearEquiv which is put into Algebra/Algebra/Basic.


Open in Gitpod

discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.2312849.20relax.20condition.20of.20Subalgebra.2Eeq_bot_of_finrank_one

acmepjz avatar May 12 '24 18:05 acmepjz

Seems that a lot of results in this file can be relaxed by the same way. Maybe I'll investigate them later. It's welcomed if someone could compile a list of them.

acmepjz avatar May 12 '24 18:05 acmepjz

Since #12963 is merged, is it a good idea to move the results in this PR to that file?

acmepjz avatar May 22 '24 09:05 acmepjz

Thanks! maintainer merge

erdOne avatar May 24 '24 09:05 erdOne

🚀 Pull request has been placed on the maintainer queue by erdOne.

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

:v: acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar May 24 '24 09:05 mathlib-bors[bot]

bors r+

acmepjz avatar May 24 '24 11:05 acmepjz

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar May 24 '24 12:05 mathlib-bors[bot]