mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

Eisenstein series are modular forms

Open CBirkbeck opened this issue 1 year ago • 1 comments
trafficstars

We show Eisenstein series are modular forms.


  • [ ] depends on: #12456 Open in Gitpod

CBirkbeck avatar May 02 '24 16:05 CBirkbeck

This PR/issue depends on:

  • ~~leanprover-community/mathlib4#12456~~ By Dependent Issues (🤖). Happy coding!

PR summary 255342ca38

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.ModularForms.EisensteinSeries.ModularForm 1847

Declarations diff

+ _root_.eisensteinSeries + eisensteinSeries_MF - eisensteinSeries

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

github-actions[bot] avatar Jul 08 '24 18:07 github-actions[bot]

:v: CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors[bot] avatar Jul 09 '24 08:07 mathlib-bors[bot]

As for the TODO, I already have this, but its waiting on the q-expansion stuff thats coming. Should that still be a todo if its in the process of being PRd?

CBirkbeck avatar Jul 09 '24 12:07 CBirkbeck

As for the TODO, I already have this, but its waiting on the q-expansion stuff thats coming. Should that still be a todo if its in the process of being PRd?

I would do so - the next PR can remove the TODO. If that other PR doesn't land soon (for whatever reason), the current file is in a more useful state.

grunweg avatar Jul 09 '24 12:07 grunweg

bors r+

CBirkbeck avatar Jul 09 '24 13:07 CBirkbeck

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Jul 09 '24 14:07 mathlib-bors[bot]