mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat: add `image_restrictPreimage`

Open BGuillemet opened this issue 1 year ago • 2 comments

  • add the theorem image_restrictPreimage; use it to simplify the proof of Set.restrictPreimage_isClosedMap
  • add the equivalent for open maps Set.restrictPreimage_isOpenMap.
  • delete IsClosedMap.restrictPreimage, which duplicates Set.restrictPreimage_isClosedMap

This PR adds the theorem image_restrictPreimage and uses it to simplify the proof of Set.restrictPreimage_isClosedMap. It also adds the equivalent for open maps Set.restrictPreimage_isOpenMap. The duplicate IsClosedMap.restrictPreimage of Set.restrictPreimage_isClosedMap has been deleted.

Open in Gitpod

BGuillemet avatar Mar 24 '24 22:03 BGuillemet

Welcome to mathlib and thank you for your contribution!

Is your pull request ready for review? Then you can label it awaiting-review, so reviewers will look at it :-) (Have you seen the contribution guidelines already? They explain this detail under "Lifecycle of a PR".)

I took the liberty to tweak your PR title and description a bit: for instance, the paragraph you wrote below the line could (imho) also go into the commit message.

grunweg avatar Mar 25 '24 08:03 grunweg

Thank you very much for your advice! I hadn't seen the contribution guidelines, so I read it and added the awaiting-review label.

BGuillemet avatar Mar 25 '24 11:03 BGuillemet

Thanks!

bors merge

fpvandoorn avatar Apr 02 '24 15:04 fpvandoorn

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Apr 02 '24 17:04 mathlib-bors[bot]