mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Mathlib/LinearAlgebra/DirectSum/Finsupp): tensor products of finsupp sums

Open AntoineChambert-Loir opened this issue 1 year ago • 3 comments
trafficstars

Modules

  • TensorProduct.finsuppLeft, the tensor product of ι →₀ M and N is linearly equivalent to ι →₀ M ⊗[R] N

  • TensorProduct.finsuppScalarLeft, the tensor product of ι →₀ R and N is linearly equivalent to ι →₀ N

  • TensorProduct.finsuppRight, the tensor product of M and ι →₀ N is linearly equivalent to ι →₀ M ⊗[R] N

  • TensorProduct.finsuppLeft', if M is an S-module, then the tensor product of ι →₀ M and N is S-linearly equivalent to ι →₀ M ⊗[R] N

This is the first part of PR #10824 which contains three applications of these functions to monoid algebras, polynomials and multivariate polynomials.

It has been split because this part is reasonably sound, while the three other files are more like propositions.


Open in Gitpod

AntoineChambert-Loir avatar Mar 24 '24 20:03 AntoineChambert-Loir

Thank you very much! It looks good for me.

acmepjz avatar Mar 24 '24 23:03 acmepjz

!bench

AntoineChambert-Loir avatar Mar 27 '24 08:03 AntoineChambert-Loir

Here are the benchmark results for commit b400dac8f756ca9b992ef57fbf3d6e5dbb2cb54e. There were significant changes against commit f4fd1b19f0e2ab3989c2fef5511ab2341f8b2607:

  Benchmark                                  Metric         Change
  ================================================================
- ~Mathlib.LinearAlgebra.DirectSum.Finsupp   instructions   244.6%

leanprover-bot avatar Mar 27 '24 08:03 leanprover-bot

@alreadydone, is there something else that you would want me to add or change?

AntoineChambert-Loir avatar Apr 01 '24 15:04 AntoineChambert-Loir

Thanks for the shorter versions, I'll use them, and I'm OK to make the arguments of finsuppLeft explicit, in accordance with what is done for docs#TensorProduct.directSumLeft

AntoineChambert-Loir avatar Apr 03 '24 08:04 AntoineChambert-Loir

Can you please fix the compile errors (which probably results from the implicitness changes)? Thanks!

alreadydone avatar Apr 08 '24 15:04 alreadydone

I had not noticed that there were errors left, sorry. I make the necessary adjustments at once.

AntoineChambert-Loir avatar Apr 08 '24 17:04 AntoineChambert-Loir

Thanks 🎉 maintainer merge

alreadydone avatar Apr 08 '24 19:04 alreadydone

🚀 Pull request has been placed on the maintainer queue by alreadydone.

github-actions[bot] avatar Apr 08 '24 19:04 github-actions[bot]

Thanks!

bors merge

ocfnash avatar Apr 08 '24 20:04 ocfnash

Pull request successfully merged into master.

Build succeeded:

mathlib-bors[bot] avatar Apr 08 '24 20:04 mathlib-bors[bot]