mathlib4
mathlib4 copied to clipboard
feat(Mathlib/LinearAlgebra/DirectSum/Finsupp): tensor products of finsupp sums
Modules
-
TensorProduct.finsuppLeft, the tensor product ofι →₀ MandNis linearly equivalent toι →₀ M ⊗[R] N -
TensorProduct.finsuppScalarLeft, the tensor product ofι →₀ RandNis linearly equivalent toι →₀ N -
TensorProduct.finsuppRight, the tensor product ofMandι →₀ Nis linearly equivalent toι →₀ M ⊗[R] N -
TensorProduct.finsuppLeft', ifMis anS-module, then the tensor product ofι →₀ MandNisS-linearly equivalent toι →₀ M ⊗[R] N
This is the first part of PR #10824 which contains three applications of these functions to monoid algebras, polynomials and multivariate polynomials.
It has been split because this part is reasonably sound, while the three other files are more like propositions.
Thank you very much! It looks good for me.
!bench
Here are the benchmark results for commit b400dac8f756ca9b992ef57fbf3d6e5dbb2cb54e. There were significant changes against commit f4fd1b19f0e2ab3989c2fef5511ab2341f8b2607:
Benchmark Metric Change
================================================================
- ~Mathlib.LinearAlgebra.DirectSum.Finsupp instructions 244.6%
@alreadydone, is there something else that you would want me to add or change?
Thanks for the shorter versions, I'll use them, and I'm OK to make the arguments of finsuppLeft explicit, in accordance with what is done for docs#TensorProduct.directSumLeft
Can you please fix the compile errors (which probably results from the implicitness changes)? Thanks!
I had not noticed that there were errors left, sorry. I make the necessary adjustments at once.
Thanks 🎉 maintainer merge
🚀 Pull request has been placed on the maintainer queue by alreadydone.
Thanks!
bors merge
Pull request successfully merged into master.
Build succeeded: