mathlib4 icon indicating copy to clipboard operation
mathlib4 copied to clipboard

feat(Order/KrullDimension): add some basic lemmas about krull dimension of a preorder

Open jjaassoonn opened this issue 1 year ago • 4 comments
trafficstars

  • krull dimension, height, coheight interacting with functions
  • order dual

These will be specialized to ring theoretic krull dimension later


  • [ ] depends on:#11730

Open in Gitpod

jjaassoonn avatar Mar 04 '24 13:03 jjaassoonn

What's your use case for KrullDimOfRel?

I have no other use of KrullDimOfRel other than specializing it into KrullDim. But I thought I could add it for the sake of generality.

jjaassoonn avatar Mar 27 '24 19:03 jjaassoonn

Then let's turn it into a note instead. I doubt people will ever need it.

YaelDillies avatar Mar 27 '24 20:03 YaelDillies

No sorry I meant "let's remove the definition and add a note about how we could have it but don't because nobody needs it".

YaelDillies avatar Mar 27 '24 20:03 YaelDillies

No sorry I meant "let's remove the definition and add a note about how we could have it but don't because nobody needs it".

Thanks for the clarification and sorry for the misunderstanding. Only after I removed krullDimOfRel, I realized that it might be useful afterall, because a composition series is a relation series of \covby, anyway, If it turns out to be useful, I will open another PR and revert the change I guess.

jjaassoonn avatar Mar 27 '24 22:03 jjaassoonn