mathlib icon indicating copy to clipboard operation
mathlib copied to clipboard

feat(algebra/module/graded_module): define graded module

Open jjaassoonn opened this issue 3 years ago • 5 comments

By imitating the current graded_algebra, this pr builds graded_module over some graded algebra

Co-authored-by: Eric Wieser @eric-wieser

  • [x] depends on: #14626
  • [x] depends on: #15654

Open in Gitpod

jjaassoonn avatar Jun 06 '22 21:06 jjaassoonn

It might make sense to handle #14583 first, so that we can avoid having extra scalar rings here.

eric-wieser avatar Jun 06 '22 22:06 eric-wieser

There is a weird issue: if I put instances like set_like \sigma A etc inside def/lemma, then Lean can find them, but if I put them in variables, then Lean cannot find them.

jjaassoonn avatar Jun 30 '22 15:06 jjaassoonn

You probably need an include \sigma line to make lean aware that you intend to refer to \sigma

eric-wieser avatar Jun 30 '22 15:06 eric-wieser

This works, thanks

You probably need an include \sigma line to make lean aware that you intend to refer to \sigma

jjaassoonn avatar Jun 30 '22 19:06 jjaassoonn

This PR/issue depends on:

  • ~~leanprover-community/mathlib#14626~~
  • ~~leanprover-community/mathlib#15654~~ By Dependent Issues (🤖). Happy coding!

@eric-wieser, this PR has been forgotten by me and you. Could you please have a look again please. Thanks.

jjaassoonn avatar Oct 05 '22 19:10 jjaassoonn

Hmm, this merge didn't go well ... Shouldn't have squash-merged ... should be fine now.

alreadydone avatar Jan 26 '23 18:01 alreadydone

Pull request successfully merged into master.

Build succeeded:

bors[bot] avatar Jan 27 '23 20:01 bors[bot]