batteries icon indicating copy to clipboard operation
batteries copied to clipboard

fix: use `by rfl` instead of `rfl` to bypass new compiler bug

Open Shreyas4991 opened this issue 1 year ago • 3 comments
trafficstars

This is a workaround for a bug reported on the zulip thread

Shreyas4991 avatar Sep 27 '24 23:09 Shreyas4991

awaiting-review

Shreyas4991 avatar Sep 27 '24 23:09 Shreyas4991

Mathlib CI status (docs):

This works and it's simple but the ideal is an upstream solution, so we should wait a bit for a better solution from lean4#5502. Otherwise, I would approve.

fgdorais avatar Sep 28 '24 02:09 fgdorais

I think by rfl will always be more robust than rfl regardless of core changes. I am inclined to merge this but want to check with @fgdorais

mattrobball avatar Nov 04 '24 16:11 mattrobball

I can't reproduce the original bug since v4.13-rc1. I'm not sure why the issue isn't closed upstream.

fgdorais avatar Nov 04 '24 18:11 fgdorais

I went out to 68 and the problem is gone so let's close this.

It would be informative to ping on leanprover/lean4#5502 to see if any changes directed at this landed.

mattrobball avatar Nov 04 '24 20:11 mattrobball