batteries icon indicating copy to clipboard operation
batteries copied to clipboard

feat: add `ByteSubarray`

Open fgdorais opened this issue 1 year ago • 1 comments

Alternative to #836. While this is not quite a drop-in replacement for users of Mathlib's ByteSlice, it offers the same functionality while using the same basic structure as core's Subarray type.

This fixes the issues I raised in #836 but I'm also happy with compromises. For example, I personally think ByteSlice is a better name than ByteSubarray. I'm also a fan of the offset/length approach but this seems to much of a divergence from Subarray.

fgdorais avatar Jun 17 '24 13:06 fgdorais

I have no particular opinion here (as I don't know of any use cases yet), but I will happily deprecate Mathlib's ByteArray in favour of this when it is merged.

kim-em avatar Jul 25 '24 00:07 kim-em