batteries icon indicating copy to clipboard operation
batteries copied to clipboard

`runLinter` should determine the target module by asking Lake

Open kim-em opened this issue 1 year ago • 2 comments

kim-em avatar May 13 '24 07:05 kim-em

I created draft PR #811, in which the current target module is either the first lean_exe root module or the module corresponding to the first lean_lib in Lake's environment. However, I assume we want a more flexible default.

What criteria should we use to determine the target module(s)? Are there cases where we want to run the linter on multiple modules by default?

If we are okay with linting multiple modules by default, what about "lint all modules inside either a default target lean_exe root or default target lean_lib in the Lake workspace"?

austinletson avatar May 26 '24 14:05 austinletson

I have updated #811 to use any root modules of lean_exe or lean_lib default targets.

austinletson avatar May 30 '24 21:05 austinletson