batteries
batteries copied to clipboard
feat: fix some issues with `equals t => tac`
This PR fixed some issues with the conv tactic equals t => tac:
- It gives bad error messages when
thas the wrong type. For example,type mismatch this has type ?m.6391 = 1 : Prop but is expected to have type 3 = ?m.6381 : Prop - The use of
show (_ = $t)means that ifthas exposed function dots, something like
will turn intoequals · => tacs
andtactic => show (_ = ·); next => tacs(_ = ·)will elaborate asfun x => _ = x, which is probably unexpected.
Mathlib CI status (docs):
- ✅ Mathlib branch batteries-pr-testing-1291 has successfully built against this PR. (2025-06-27 13:44:22) View Log
This needs tests.