batteries icon indicating copy to clipboard operation
batteries copied to clipboard

feat: fix some issues with `equals t => tac`

Open plp127 opened this issue 5 months ago • 2 comments

This PR fixed some issues with the conv tactic equals t => tac:

  • It gives bad error messages when t has the wrong type. For example,
    type mismatch
      this
    has type
      ?m.6391 = 1 : Prop
    but is expected to have type
      3 = ?m.6381 : Prop
    
  • The use of show (_ = $t) means that if t has exposed function dots, something like
    equals · => tacs
    
    will turn into
    tactic => show (_ = ·); next => tacs
    
    and (_ = ·) will elaborate as fun x => _ = x, which is probably unexpected.

plp127 avatar Jun 26 '25 11:06 plp127

Mathlib CI status (docs):

This needs tests.

fgdorais avatar Jul 03 '25 01:07 fgdorais