batteries icon indicating copy to clipboard operation
batteries copied to clipboard

chore: upstream shake from Mathlib to Batteries

Open Vierkantor opened this issue 7 months ago • 3 comments
trafficstars

The shake command doesn't depend on Mathlib so let's upstream it and make it available for other projects.

This version still has some settings hardcoded to use Mathlib as default. In #1205 I change this to use Lake's default targets instead.

Mathlib adaptation PR: https://github.com/leanprover-community/mathlib4/pull/23916

Zulip discussion: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Spinning.20off.20.60mathlib-linters.60.20and.20.60shake.60.20repo

Vierkantor avatar Apr 10 '25 12:04 Vierkantor

Mathlib CI status (docs):

I have tested that shake does sensible things, and indeed it reports quite a few files in Batteries can be shaken! The default target to run shake on is still Mathlib, currently working on making Lake tell me the default target instead. But I think we can leave that to a follow-up PR.

Vierkantor avatar Apr 10 '25 13:04 Vierkantor

Sure, I agree. Can you add the default target bit to the PR description? (I cannot.)

grunweg avatar Apr 10 '25 13:04 grunweg

What is the status of this PR?

fgdorais avatar Jun 03 '25 21:06 fgdorais

It looks to me like the discussion on Zulip about whether shake should be in its own repository is still unresolved.

bryangingechen avatar Jun 04 '25 16:06 bryangingechen