phaser-es6-webpack icon indicating copy to clipboard operation
phaser-es6-webpack copied to clipboard

Phaser 3

Open leandr0ck opened this issue 8 years ago • 14 comments

I have create the branch 'phaser3' to start with the implementation of the new release of the library. Does anyone have any ideas or suggestions to implement? Any functionality to add or remove?

There are some ideas:

  • implement an scaffolding tool like Yeoman
  • more documentation
  • create some common components or utilities

leandr0ck avatar Oct 31 '17 15:10 leandr0ck

  • Implement Phaser Manifest Loader for Webpack which provides an easy way to load assets : https://github.com/mattcolman/phaser-manifest-loader (+ it is based on this repo so it easy to implement)

  • Create a folder with a file implementing the main webpack config and extend it to a dev/prod/cordova... like that if you wants to add a plugin to your webpack config you don't have to copy/paste the same lines in every environnement (webpack.conf, webpack.deploy) <-- I could do that

RenaudRohlinger avatar Oct 31 '17 16:10 RenaudRohlinger

it would be nice if you could add support for electron. that way you d have mobile desktop and web on the same template :)

Raagh avatar Dec 13 '17 21:12 Raagh

What you think about add something like https://github.com/mixtur/webpack-spritesmith, then we could easily merge all the image assets into a atlas on the build (and in dev runtime). I'm playing with this idea in a old fork of your repo, if you want to check it out: https://github.com/RafaelDelboni/phaser-dungeon

rafaeldelboni avatar Jan 08 '18 14:01 rafaeldelboni

Maybe it's possible to add Webpack's Hot Module Replacement ( https://webpack.js.org/concepts/hot-module-replacement/ )

thisredone avatar Jan 20 '18 12:01 thisredone

Hi, I think we need to separate the upgrade to phaser 3 from the other enhancements, that way we could consume it in smaller chunks.

I'll try to upgrade it to phaser 3 and make a pull request for it. Are you still up to merge it? @lean

EDIT: After looking through the phaser3 branch, I've seen it's mostly complete regarding upgrading to phaser3, is there anything missing that prevents you from merging to master?

oronbz avatar Sep 06 '18 09:09 oronbz

Don't worry about the merge, I will do manually because I was planning to move the v2 to another repo. So let me check your work and I will integrate it with what I have been doing

leandr0ck avatar Sep 06 '18 12:09 leandr0ck

I've made something very similar some time ago, maybe it helps as source of inspiration: https://github.com/rafaeldelboni/phaser3-es6-webpack4

rafaeldelboni avatar Sep 06 '18 12:09 rafaeldelboni

@lean I'm not worried. I just don't want to repeat / duplicate work that already has been done. Is there anything else needed to be done on top of your phaser3 branch in order to support Phaser 3.0?

oronbz avatar Sep 06 '18 13:09 oronbz

@oronbz cool, let me update some things. I will tell you when I'm ready

leandr0ck avatar Sep 06 '18 14:09 leandr0ck

@rafaeldelboni thanks for share your project. I'm looking at it right now

leandr0ck avatar Sep 06 '18 14:09 leandr0ck

@oronbz I just updated https://github.com/lean/phaser-es6-webpack/tree/phaser3 Now is running with webpack 4 and babel 7

leandr0ck avatar Sep 06 '18 14:09 leandr0ck

@lean that's awesome, Is there any reason you haven't included cordova too?

oronbz avatar Sep 07 '18 16:09 oronbz

I haven't include for lack of time. I even think it's still incomplete. We need to add:

  • webpack config for production
  • cordova support

leandr0ck avatar Sep 07 '18 16:09 leandr0ck

For newcomers like me it would be useful to update the ReadME with some information about the v3 branch and any steps needed to use it (if any). Some ppl will just assume there's no v3 support yet.

jay-jlm avatar Sep 12 '18 17:09 jay-jlm