gh-actions-lua icon indicating copy to clipboard operation
gh-actions-lua copied to clipboard

Update Node to version 20

Open Rathoz opened this issue 1 year ago • 5 comments
trafficstars

Github Action is transitioning away from Node 16 as it's End of Life.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Rathoz avatar Mar 14 '24 12:03 Rathoz

@alerque may I ask when this will be merged?

britzl avatar Apr 23 '24 09:04 britzl

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

alerque avatar Apr 23 '24 13:04 alerque

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

Ah, I see. I thought you were one of the maintainers. Have you tested it on a fork to verify that it is indeed working or only looked through the changes?

britzl avatar Apr 23 '24 14:04 britzl

I believe I did, but it's been a minute. It's pretty easy to do your self if you want to verify this as an extra data point for @leafo (and/or just make use of it until it merges). You just have to change the name of the step in your own workflow to the fork behind this PR and use the patch-1 branch for the version.

alerque avatar Apr 24 '24 09:04 alerque

This will fix #42

BreakBB avatar May 14 '24 22:05 BreakBB

This is now fixed

leafo avatar Feb 27 '25 21:02 leafo

This is now fixed

In this commit 33d9166f7c77bd44847901163b079c37975a191e

BreakBB avatar Feb 28 '25 06:02 BreakBB