gh-actions-lua icon indicating copy to clipboard operation
gh-actions-lua copied to clipboard

Allow specifying install path

Open TheCycoONE opened this issue 4 years ago • 6 comments

I would like to use the resulting lua libraries in a CMake project. Right now this appears to install in whatever the current working directory is, which cannot be set for a uses action. It's actually ending up in the checkout path for my repo which is causing other issues for my file formatting scans.

It would be nice to either provide the directory e.g. with: installPath=${MY_PATH} or to expose the install path somehow to the parent action.

TheCycoONE avatar Dec 09 '20 05:12 TheCycoONE

I attempted to work around by putting these actions before - uses: actions/checkout@v2 When I did that, lua and luarocks were not in the path at all.

TheCycoONE avatar Dec 13 '20 14:12 TheCycoONE

Just use a - run: step after running this and use shell commands to move or copy the files you want wherever you want them. You'll have to set any related path variables yourself, but you can put stuff wherever you like.

alerque avatar Dec 13 '20 16:12 alerque

I too would like this as a feature: as-is, luacheck . in my repo picks up the entire .install directory.

daurnimator avatar Jan 26 '21 16:01 daurnimator

Hence why all my projects have .luacheckrc files with exclude_files = { ".install" } (along with a few other CI induced ignores).

Come to think of it, the default path should probably be somewhere in the runner's home directory and not in the project Git workspace at all.

alerque avatar Jan 28 '21 10:01 alerque

I feel like the default should really be a folder outside of github.workspace, along with an ability to specify install path. After performing leafo/gh-actions-lua and leafo/gh-actions-luarocks actions, running luarocks write_rockspec in a checked out repository results in a rockspec file that includes all the lua files from auxiliary folders aforementioned actions rely on (most notably .lua and .luarocks), which is clearly unintended behavior. https://github.com/leafo/gh-actions-luarocks could use these improvements, too.

im-mortal avatar Oct 21 '21 18:10 im-mortal

Yeah, I think will be great allow to set the installation path

Miqueas avatar Nov 11 '21 17:11 Miqueas