gh.nvim icon indicating copy to clipboard operation
gh.nvim copied to clipboard

Published 20 hours ago • verified publisher icon ldelossa

Have the ability to start a thread on the file not just the lines

Open jemershaw opened this issue 2 years ago • 3 comments

the diffview does show the comment but it doesn't seem like the user can create a thread outside of the diff lines.

jemershaw avatar Oct 06 '23 22:10 jemershaw

Can you show me what you mean here in the Github UI?

Im not immediately seeing what you mean.

We can create comments on commits, but im unaware of a "file level" commit. Could be that ive just never done this.

ldelossa avatar Oct 07 '23 00:10 ldelossa

It's a feature they added in March: https://github.blog/changelog/2023-03-14-comment-on-files-in-a-pull-request-public-beta/

rmacklin avatar Oct 07 '23 00:10 rmacklin

I would love this feature as well. I have a set of diffs in a PR that I would like to comment and start a thread on, but I have to first find the specific commit that made the change in order to be able to comment anything and this is a big limitation imo.

It would be a simpler workflow to

  1. open the PR using gh.nvim,
  2. then go to any diff on any file, and be able to call GHCreateThread which then brings up a modal filled with commits that changed the specific file ( see advanced-git-search)
  3. write your thread comment on the split-screen buffer that opens up.
  4. submit

roshaans avatar Oct 10 '23 17:10 roshaans