mossgpt-utools
mossgpt-utools copied to clipboard
lblblong
怎么用 upx 升级
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is there an existing issue for this?
- [x] I have searched the existing issues
What would you like to be added?
I belong to the IBM Power porting team. We have recently developed patches to build Milvus on ppc64le, and would like to open a PR to upstream the changes to this repo. The major changes were adjusting the versions for some conan installed dependencies, and creating a local cmake repo for conan because the conan binary package for cmake currently does not have power binaries. So we need to somehow find a way to ensure cmake supports power, and any future dependency version modifications work on all architectures. Do you have any suggestions?
Why is this needed?
There are customers who wish to use Milvus on Power.
Anything else?
Great work. The only concern is how we can deploy ci/cid to make sure the Power deployment will not be broken by some new PRs. We don't have any IBM Power machines so that might be really challenge
Hi @xiaofan-luan You can request a ppc64le node for your CI from this link: https://osuosl.org/services/powerdev/request_hosting/ (Please put "Gerrit Huizenga" in the IBM advocate field.)
Also, I have successfully built and tested Milvus 2.3.3 using our patches on Ubuntu 22.04 and RHEL 9.3, on both x86_64 and ppc64le. You will need to create a repo for "cmake/3.28.3@milvus/dev" to host cmake binaries for both Intel and Power. I hope that's fine.
cc: @seth-priya
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.
@sumitd2 sorry for the late reply.
I'm not very familiar with the compilation part. We can keep it as long as there is simple script that can run for milvus to build on Power series.
This seems to be a large pr so let's try to do this
- change knowhere to support POWER -> especially for the same functionality of SIMD
- make a script that can compile milvus
- dockerfile
Hi @xiaofan-luan, we are working on the SIMD optimizations and the PR. Will get back to you on this.
@sumitd2 I've noticed a wave of AIX-related PRs to the Faiss baseline. I will propagate these changes to our Faiss fork in Knowhere. Please feel free to let me know if you need any assistance with Faiss/Knowhere as well.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.
@sumitd2 sorry for the late reply.
I'm not very familiar with the compilation part. We can keep it as long as there is simple script that can run for milvus to build on Power series.
This seems to be a large pr so let's try to do this
- change knowhere to support POWER -> especially for the same functionality of SIMD
- make a script that can compile milvus
- dockerfile
Hi @xiaofan-luan, couple of quick points here:
- Our team that was working on SIMD has abandoned the idea. They say the compiler generated code is better than handwritten.
- A script here will not work, as it has the chance of being broken by future PRs. This will have to be a proper port with the changes going into master, and a CI node (which we can provide on osuosl.org) to include the Power CI as a job. The conan binary package for cmake currently does not have Power binaries, so we will have to find a solution for this - many of our customers are interested in Milvus on Power
Let me know your thoughts. cc: @seth-priya
@alexanderguzhva could you help with the IBM team with the milvus side change?
@locustbaby could you try to request a powerPC machine for the basic ci/cd?
@sumitd2这么晚才回复很抱歉。 我对编译部分不是很熟悉。只要有简单的脚本可以运行 milvus 在 Power 系列上构建，我们就可以保留它。 这似乎是一个很大的公关，所以让我们尝试这样做
- 更改knowhere以支持POWER -> 特别是对于SIMD的相同功能
- 制作一个可以编译milvus的脚本
- docker文件
你好@xiaofan-luan，这里有几个要点：
- 我们致力于 SIMD 的团队已经放弃了这个想法。他们说编译器生成的代码比手写的更好。
- 这里的脚本不起作用，因为它有可能被未来的 PR 破坏。这必须是一个正确的端口，更改将进入主节点，并且必须是一个 CI 节点（我们可以在 osuosl.org 上提供）以将 Power CI 作为作业包含在内。 cmake 的 conan 二进制包目前没有 Power 二进制文件，因此我们必须为此找到解决方案 - 我们的许多客户对 Milvus on Power 感兴趣
让我知道你的想法。抄送：@seth-priya
@sumitd2 sorry for the late reply. I'm not very familiar with the compilation part. We can keep it as long as there is simple script that can run for milvus to build on Power series. This seems to be a large pr so let's try to do this
- change knowhere to support POWER -> especially for the same functionality of SIMD
- make a script that can compile milvus
- dockerfile
Hi @xiaofan-luan, couple of quick points here:
- Our team that was working on SIMD has abandoned the idea. They say the compiler generated code is better than handwritten.
- A script here will not work, as it has the chance of being broken by future PRs. This will have to be a proper port with the changes going into master, and a CI node (which we can provide on osuosl.org) to include the Power CI as a job. The conan binary package for cmake currently does not have Power binaries, so we will have to find a solution for this - many of our customers are interested in Milvus on Power
Let me know your thoughts. cc: @seth-priya
we also need your help to finish the power pc compile. is there a pr for this issue?
@xiaofan-luan We built 2.3.3 and its rather old now. I am building 2.4.1 on RHEL 9.3 since the afternoon and on the face of it, it looks like it requires minimal changes.
@sumitd2 I've submitted a ticket#33429 for a powerpc
@locustbaby We have received your request, and it has been approved. Now its a matter of the administrator creating the VM, shouldn't be long.