update CloudwatchLogs credential object

[yzpaul]

trafficstars

allows user provided credentials to work. Prior version was not nested correctly therefore AWS SDK ignored it and used default credentials

[yzpaul]

@lazywithclass I'm fairly new to GitHub, should I incorporate his proposed change and do another pull request? How is this supposed to work so everything stays clean?

[lazywithclass]

Looks like you solved the problem :D

Do these changes solve the issue for you?

[yzpaul]

@lazywithclass yep, works for me, although I haven't set up an account in another region to confirm it, this seems right according to the docs

[yzpaul]

@nikhilrajaram https://github.com/nikhilrajaram is absolutely correct, I never noticed the region issue because in my testing all of my test cases were in the same region.

On Mon, Jun 27, 2022, 14:04 Alberto Zaccagni @.***> wrote:

@.**** commented on this pull request.

In index.js https://github.com/lazywithclass/winston-cloudwatch/pull/192#discussion_r907530698 :

@@ -49,7 +49,7 @@ var WinstonCloudWatch = function(options) { config = assign(config, options.awsOptions); }

• this.cloudwatchlogs = new CloudWatchLogs(config);

• this.cloudwatchlogs = new CloudWatchLogs({credentials:config});

I agree with @nikhilrajaram https://github.com/nikhilrajaram, what do you think @yzpaul https://github.com/yzpaul?

— Reply to this email directly, view it on GitHub https://github.com/lazywithclass/winston-cloudwatch/pull/192#discussion_r907530698, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKDOOXXCLCGCLPMFCOWAETVRHUKDANCNFSM5ZOOYUQA . You are receiving this because you were mentioned.Message ID: @.***>

[lazywithclass]

@yzpaul sorry I am confused by your last comment, is the region issue solved by your last push?

If so I will test this in different regions and then publish a new version.