layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[Sistent] Move `code` section of identity to table format

Open sudhanshutech opened this issue 1 year ago • 20 comments

Current Behavior

The identity section under https://layer5.io/projects/sistent/identity/color like color, typography and spacing these sections code part is currently a image so user can't copy the color code.

Desired Behavior

Move these images to table format instead of images, same structure just use table to display the colors and rest code section of identity. Design can be found here: Figma

Screenshots / Mockups

Implementation

Acceptance Tests


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

sudhanshutech avatar Jul 11 '24 05:07 sudhanshutech

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 11 '24 05:07 github-actions[bot]

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 11 '24 05:07 github-actions[bot]

For color -> code section an issue has already been opened.

Aviral0702 avatar Jul 11 '24 05:07 Aviral0702

https://github.com/layer5io/sistent/issues/646

Aviral0702 avatar Jul 11 '24 05:07 Aviral0702

Ok . Can i take up this issue ?

Aviral0702 avatar Jul 11 '24 06:07 Aviral0702

Hey @sudhanshutech I would like to work on this issue

mannika763 avatar Jul 11 '24 10:07 mannika763

@Aviral0702 you have few issues assigned in meshery , lets give this issue to @mannika763 and you can assist and review the pr when it will be raised.

sudhanshutech avatar Jul 11 '24 11:07 sudhanshutech

@Aviral0702 you have few issues assigned in meshery , lets give this issue to @mannika763 and you can assist and review the pr when it will be raised.

Sure @sudhanshutech

Aviral0702 avatar Jul 11 '24 11:07 Aviral0702

Hey @sudhanshutech I would like to confirm a few things. These images need to be converted into code form. We have sections for color, spacing, and typography, and within each of them, we have overview, guidance, and code. Should these changes be applied to each section?

mannika763 avatar Jul 11 '24 17:07 mannika763

In code section, just put the colors in table and ui should be same as current just it should not be a image but content inside table

sudhanshutech avatar Jul 14 '24 13:07 sudhanshutech

@mannika763 i am seeing you are already working on a issue, will you be managing this also?

sudhanshutech avatar Jul 14 '24 18:07 sudhanshutech

@sudhanshutech yeah, can manage. otherwise i'll post a message here. Thank you for asking

mannika763 avatar Jul 15 '24 03:07 mannika763

Hey @sudhanshutech, I would like to confirm if there is any table-related component available in Layer5, or should I create table from scratch? Thanks!

mannika763 avatar Jul 16 '24 16:07 mannika763

Hey @sudhanshutech I apologize for any inconvenience, but I am currently a bit busy with my work. Therefore, I am unassigning this task from my name so that others can work on it and close it earlier. Thank you for your understanding.

mannika763 avatar Jul 25 '24 07:07 mannika763

@sudhanshutech Can you please assign this issue to me?

siddharthbaleja7 avatar Jul 28 '24 19:07 siddharthbaleja7

here you go @siddharthbaleja7

sudhanshutech avatar Jul 29 '24 08:07 sudhanshutech

you are aware of the issue right @siddharthbaleja7 ?

sudhanshutech avatar Jul 29 '24 08:07 sudhanshutech

@sudhanshutech Sorry I am not aware of this issue.

siddharthbaleja7 avatar Aug 02 '24 20:08 siddharthbaleja7

@sudhanshutech Hello, @siddharthbaleja7 just unassigned himself, can i take it issue forward ?

BarryByte avatar Aug 02 '24 20:08 BarryByte

@sudhanshutech Update : Styling and logic part is complete, now i just need to harcode the 100s token, values and description etc. Here is the sample, please look into it. Screenshot from 2024-08-07 01-56-16 Screenshot from 2024-08-07 01-56-23

BarryByte avatar Aug 06 '24 20:08 BarryByte

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 02:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Apr 27 '25 09:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar May 01 '25 01:05 stale[bot]