lavaplayer
lavaplayer copied to clipboard
lavalink-devs
Use WEB client, add 403 retry (Fix "Video returned by Youtube is not what was requested")
Should fix https://github.com/lavalink-devs/Lavalink/issues/1030 by switching from ANDROID client to WEB.
To minimize the chances of encountering a 403 due to the odd invalid cipher resolving, I've implemented a basic 403 retry mechanism that will aim to fetch a new stream URL up to 3 times before throwing.
Maybe playlists will work with the new player params from https://github.com/lavalink-devs/lavaplayer/pull/93 ?
Can someone explain? I don't understand how this supersedes #93 because I don't see any file overlap 😕 What am I missing? Is the whole client being changed away from Android and that is why version is irrelevant now?
What is there to explain? ANDROID breaks every other week so we changed the client back to WEB (what it originally was many moons ago) which appears to be more reliable, as evidenced by the fact many users have been running this PR in various forms over the last week or so.
https://github.com/lavalink-devs/lavaplayer/pull/88/files#diff-3d9550aeb292216eaf9f44301e329a2df287b7a84b5697ed4a26cd5c1296e1abR224
I don't understand what you're asking.
This change will likely be superseded by my rewritten source manager once I make a release for it anyway. The entire lot has been refactored and restructured so this doesn't matter. It was just a dirty fix so we could at least release a working jar.
Superseded by https://github.com/lavalink-devs/youtube-source
Users are advised to move to that as it's likely that the built-in source manager will be deprecated soon. Leaving this PR open until plans have been finalized in the form of a release to bring awareness to this change.