Daniel Smith

Results 138 comments of Daniel Smith

https://github.com/kubernetes/kubernetes/blob/ea4c28c7f86372b82aa8a8a15c9cbdf07098c49a/cmd/kube-controller-manager/app/controllermanager.go#L405 Maybe it doesn't *work* but I don't see how you can say this is unused?

(e.g. perhaps the validation routine should make sure that the disabled by default controllers are real controllers)

> Maybe it's just for post-expansion. Perhaps-- such users should really have a test case in-tree to make it clear what it's for. Or maybe something happened to it and...

I'm not very excited about clients parsing RV, our explicit guidance is to not do that. You can use `.generation` for this if your changes are in the spec. Ideal...

> The final commit only compares opaque ResourceVersion strings, without the "is newer" comparison. It therefore cannot guarantee anymore that the client always gets the latest revision of the object,...

> The "is equal" comparison does not depend on that. The logic is "if the AssumeCache currently holds the same object that I modified, then it is safe to replace...

> It's entirely stateless and will just react to whatever it currently gets from the cache. That means you can have oscillation and actuation amplification. (user changes A->B; controller changes...

A is "needs to be allocated", B is "allocated", C is "needs to be deallocated", D is "unallocated" I don't know the specifics enough to say the exact sequence that...

Let's leave this open at least until the sig discusses this.