Laurent Thiebault

icon indicating a website link lauthieb.dev icon indicating an email [email protected]

icon company @Decathlon icon location Lille, France icon location Engineering Manager & Design System Lead at @Decathlon publishing Engineering, Product, Design, Tech, Business & Productivity content to the community

Results 69 comments of Laurent Thiebault

Cannot read properties of undefined (reading 'isBatchingLegacy')

Same here

How do you refer to files in the DTCG format?

I also like the idea of "Design Tokens source files", a way of acknowledging that these files are there to be a single source of truth for design decisions cut...

feat(@vtmn): add rel attribute for blank link targets to prevent security issues

@thibault-mahe for me that's ok. If we are sure there's no breaking change, you can merge it directly. If there are breaking changes, please merge & inform all our consumers....

fix(@vtmn/css, @vtmn/react, @vtmn/vue, @vtmn/svelte): linear progressbar animation

Hi @Tlahey, can you please check again? Thanks in advance :)

Geolocalization

Génial @bosseludovic ! Est-ce que quelqu'un peut checker ce développement hyper utile svp ?

Status object: simplified audit/decision history

@hereinthehive it's interesting your proposal. Maybe that could be aside from the design tokens file. In order to avoid the mix between the current source of truth and its history/changelog?...

feat(@vtmn/svelte, @vtmn/react): added `onClose` and `onOpen` directives on both React & Svelte `VtmnAccordion` components

> For some reason, on the Svelte package, I was unable to add the on:close & on:open directives into the events section, instead there are interpretated as regular props, leaving...

feat(@vtmn/svelte, @vtmn/react): added `onClose` and `onOpen` directives on both React & Svelte `VtmnAccordion` components

Hi @DKT-cdrag, just converted to draft as @Tlahey give you some comments. Feel free to make this pr "ready for review" again when you will be ready for a new...

feat(@vtmn/svelte, @vtmn/react): added `onClose` and `onOpen` directives on both React & Svelte `VtmnAccordion` components

Hi @DKT-cdrag, are you okay to do these changes? Thanks :)

feat(@vtmn/svelte, @vtmn/react): added `onClose` and `onOpen` directives on both React & Svelte `VtmnAccordion` components

@DKT-cdrag this PR is stale for weeks. In order to have visibility, can we close it for now, and you can reopen it when you will be available? Thanks :)