angular-payments icon indicating copy to clipboard operation
angular-payments copied to clipboard

Move ownership of this repo?

Open vkammerer opened this issue 10 years ago • 9 comments

Hi @laurihy ,

You haven't replied to any of the issues filed in the last months. Do you want to transfer the ownership of this repo to someone who could dedicate enough time to maintain it?

vkammerer avatar Mar 12 '15 15:03 vkammerer

Hey @vkammerer,

I wrote:

https://github.com/bendrucker/angular-credit-cards https://github.com/bendrucker/angular-stripe

Those two cover almost all the features of angular-payments, with the exception of card formatting (which is coming with heavy unit + Protractor testing). They also have 100% test coverage and better organized APIs.

Given the long backlog here, I'm very interesting in bringing users over to those two libraries and reviewing feature requests.

bendrucker avatar Mar 18 '15 12:03 bendrucker

@bendrucker :+1:

gaboesquivel avatar Mar 26 '15 20:03 gaboesquivel

Thank you for sharing the info @bendrucker. I would be very interested in it as soon as card formatting is supported :+1:

alepee avatar Mar 31 '15 08:03 alepee

For those interested, I shipped a number of upstream updates this weekend:

The latter is particularly relevant for people who want formatting. I'll see if I can cut a prerelease this week since the minimum number of test cases I'm willing to ship with will presumably take longer to write than the actual code.

bendrucker avatar Mar 31 '15 11:03 bendrucker

Also, if there were any doubts about how hard input masking can be:

Stripe shipping bugs to production!

Stripe Checkout, with a bunch of talented engineers serving a ton of users, ships with easily reproducible formatting bugs. Formatting definitely helps fewer users mistype their card number, but the net effect is small if it also royally pisses off users who catch their own typo. So I'd definitely encourage people to pick battle tested code versus opting for a feature like formatting at the cost of bugs and a poor API.

Planning to ship formatting this month as an opt-in and eventually transition it to an opt-out.

bendrucker avatar Mar 31 '15 11:03 bendrucker

@bendrucker cool! thanks

gaboesquivel avatar Mar 31 '15 14:03 gaboesquivel

Formatting is now available behind the cc-format attribute in angular-credit-cards 2.3. The cursor positioning isn't perfect quite yet, but it also relies on Angular's native input handling. I'd like to nail every possible case eventually but this is a good compromise for now. Usability-wise I think it generally comes out comfortably ahead of jquery.payment / Stripe Checkout with 1/10th the code.

bendrucker avatar May 04 '15 14:05 bendrucker

Note that the repos above

https://github.com/bendrucker/angular-credit-cards https://github.com/bendrucker/angular-stripe

aren't being actively developed either, as the author doesn't "use Angular anymore". See https://github.com/bendrucker/angular-credit-cards/issues/67 and use at your own risk.

tyrw avatar Sep 18 '15 23:09 tyrw

@twler He also doesn't push his built libraries to npm so they're essentially useless for people who only want to use gulp/grunt.

buildjosh avatar Apr 28 '16 19:04 buildjosh