laurent-clouet
Feature: make stats and last rendered frame panels collapsible
The visual footprint of the client is quite big (520x800 px). This PR allows the use to collapse/expand any of the Global stats, Session infos and Last uploaded frame panels to reduce the vertical visual footprint.
Screenshot (with all panels collapsed)
As a user i like to have my choice saved from the session to another.
As a user i like to have my choice saved from the session to another.
I agree @laurent-clouet but this is MVP. We can deliver to the users a feature that is useful and covers 90% of the expected functionality. We can add saving the user preference between sessions in a future weekly release. The reason why is not included in the current version is that the existing configuration lifecycle became messy with time and the code needs a serious refactoring. It's not developer friendy and prone to mistakes. I have started the task of rebuilding from scratch the whole configuration process/saving to make it easier in the future. As soon as it's finished we can easily add a couple of lines to save the state between sessions (and many others -thinking in Window position).
On my ubuntu20.04 with kde i have an issue when i launch the client.
Once i click on it, it extends to the maximum side and them i can collapse if needed.
On my ubuntu20.04 with kde i have an issue when i launch the client.
Once i click on it, it extends to the maximum side and them i can collapse if needed.
You mean the top Project panel where lines seem to be closer than the rest? Can you check the new version that I just pushed with the new master rebased?
I tested on a different machine on win10, i have the same issue with the newer version.
I click on anywhere on the window, it expends to the "regular" screen (about 800px height).
Hi, @luguina Thanks for PR, its a feature i will definitively use!
I was wondering, on the user setting panel, we already can collapse panels, is it more or less the same implementation?
@laurent-clouet I guess you have this problem in the actual setting tab (already using collapsible panel on stable version of client)?
Hi, @luguina Thanks for PR, its a feature i will definitively use!
I was wondering, on the user setting panel, we already can collapse panels, is it more or less the same implementation?
Thanks @tuxun. It uses the same implementation of collapsible panels you have in the Settings. The difference is the current client has a fixed size and this PR "calculates" the correct size based on the status of the panels (collapsed/opened). Because the Swing events work (working much better with modern UI libraries like JavaFX), is not until you put the focus in the application window when the proper measurement is done. That's why the initial instantiation of the app doesn't properly calculate the layout and "compress" the information but when you select the window it's calculated properly.
I think I have a way of working around the problem and will try tonight. Stay tuned!