ios-client-sdk icon indicating copy to clipboard operation
ios-client-sdk copied to clipboard

Published 20 hours ago • verified publisher icon launchdarkly

Update Package.swift to support swift-tools-version:5.8

Open pierre-wehbe opened this issue 2 years ago • 3 comments

Requirements

  • [X] I have added test coverage for new or changed functionality
  • [X] I have followed the repository's pull request submission guidelines
  • [X] I have validated my changes against all supported platform versions

Related issues

swift-tools-version:5.8 have deprecated the use of .package(name:xxx, url:xxx, from:xxx) to .package(url:xxx, from:xxx). This causes our internal SPM using 5.8 to break

Describe the solution you've provided

Update LD SPM to support 5.8

pierre-wehbe avatar Sep 12 '23 23:09 pierre-wehbe

In case 5.8 is a concern (since it becomes the minimum), I believe keeping 5.2 would still work

pierre-wehbe avatar Sep 13 '23 17:09 pierre-wehbe

Hi @pierre-wehbe , thanks for opening this PR. One of our team will take a look to verify this has no adverse effects on our packages. Thank you!

tanderson-ld avatar Sep 14 '23 17:09 tanderson-ld

HI @pierre-wehbe . We will be releasing support for XCode15 in the near future. During this work, we looked at the swift-tools-version you have proposed. Unfortunately that bump would be too drastic for our customer base at the moment. We are going to be bumping it from 5.2 to 5.3 however. Are you able to have your build process ignore the deprecation?

tanderson-ld avatar Oct 24 '23 15:10 tanderson-ld