sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Add Support For Postgres Full Text Search tsvector Data Type

Open anshap1719 opened this issue 2 years ago • 12 comments

Closes #2705

Relates to #729

anshap1719 avatar Sep 01 '23 16:09 anshap1719

Hi @abonander, please approve the workflow run, it should now be fixed.

anshap1719 avatar Sep 20 '23 07:09 anshap1719

Hi @abonander, Did you get a chance to look at this again yet?

anshap1719 avatar Oct 04 '23 11:10 anshap1719

I review PRs as I get to them. SQLx is only a small part of my full-time job. Pinging me just fills up my notifications, it won't get your PR reviewed any faster.

abonander avatar Oct 12 '23 01:10 abonander

@abonander I understand. Apologies for bothering you with those.

anshap1719 avatar Oct 12 '23 12:10 anshap1719

@anshap1719 can you please rebase and fix conflicts one last time? We're ready to merge this.

Note that the type mappings for the macros have moved to their corresponding database drivers: https://github.com/launchbadge/sqlx/blob/02c68a46c7c64b03b2a4eb7375041e0ca86d2fe5/sqlx-postgres/src/type_checking.rs#L10

abonander avatar Mar 30 '24 22:03 abonander

Thanks @abonander, I have updated this PR.

anshap1719 avatar Mar 31 '24 07:03 anshap1719

Looks like cargo fmt needs to be run.

abonander avatar Mar 31 '24 10:03 abonander

@abonander Right, my bad. Done now.

anshap1719 avatar Mar 31 '24 11:03 anshap1719

@wyhaya Thanks for the review. Will make the changes over the weekend and will also use all the cases you described as test cases.

anshap1719 avatar Apr 02 '24 06:04 anshap1719

@wyhaya Updated everything. Thanks for the code as well.

anshap1719 avatar Apr 08 '24 12:04 anshap1719

Hi @abonander Just FYI, this PR no longer covers tsquery. I removed it since I realized it's not ready and needs a lot of work, and the tsvector is already done and we want to avoid blocking that.

anshap1719 avatar Apr 21 '24 08:04 anshap1719

Oh, guys sorry, but I really need tsvector support, can you check and merge it? @abonander

KirDontsov avatar May 13 '24 23:05 KirDontsov

Closing due to inactivity. Feel free to reopen as a new PR, but please address my review comments.

abonander avatar Jul 22 '24 22:07 abonander

@abonander I don't think I will. Thanks.

anshap1719 avatar Jul 23 '24 04:07 anshap1719