sqlx
sqlx copied to clipboard
Add Support For Postgres Full Text Search tsvector Data Type
Closes #2705
Relates to #729
Hi @abonander, please approve the workflow run, it should now be fixed.
Hi @abonander, Did you get a chance to look at this again yet?
I review PRs as I get to them. SQLx is only a small part of my full-time job. Pinging me just fills up my notifications, it won't get your PR reviewed any faster.
@abonander I understand. Apologies for bothering you with those.
@anshap1719 can you please rebase and fix conflicts one last time? We're ready to merge this.
Note that the type mappings for the macros have moved to their corresponding database drivers: https://github.com/launchbadge/sqlx/blob/02c68a46c7c64b03b2a4eb7375041e0ca86d2fe5/sqlx-postgres/src/type_checking.rs#L10
Thanks @abonander, I have updated this PR.
Looks like cargo fmt needs to be run.
@abonander Right, my bad. Done now.
@wyhaya Thanks for the review. Will make the changes over the weekend and will also use all the cases you described as test cases.
@wyhaya Updated everything. Thanks for the code as well.
Hi @abonander Just FYI, this PR no longer covers tsquery. I removed it since I realized it's not ready and needs a lot of work, and the tsvector is already done and we want to avoid blocking that.
Oh, guys sorry, but I really need tsvector support, can you check and merge it? @abonander
Closing due to inactivity. Feel free to reopen as a new PR, but please address my review comments.
@abonander I don't think I will. Thanks.