mcp-agent
mcp-agent copied to clipboard
lastmile-ai
Add configurable headers to SSE connections
As per #54
I would advise against merging until I update this message, as I haven't tested running without any passed headers and would hate to break something. Even if there is seemingly no way I broke it :')
@Nicba1010 thanks! Would also appreciate an example maybe added to the examples folder, and some validation steps
Sure thing, but it will have to wait till the weekend, just leave this open, I'll set a notification for myself to do it. I'm a bit swamped with work right now so I needed to implement it quick :)
Is there already an example for connecting to an SSE server at all?
If not, you can assign at least that part of #41 to me. I'll add both a simple SSE example and a SSE + headers example.
Hi, thanks for asking, it has been an extremely busy 2 weeks, I hope to finish it today, finally got some free time. Ironically, I think SSE is going out of the picture and MCP is moving to HTTP. I think I saw something like that, I need to check.
Thanks @Nicba1010! For some reason I'm not seeing you latest commit https://github.com/lastmile-ai/mcp-agent/commit/423ec42bd021a9b534fb518e9a8d03ccf3cdec4d show up in the PR. Can you check if there's anything about the fork or branch causing this? Feel free to close and recreate the PR
@Nicba1010 #116 just got merged and it added the headers for SSE. I quite like your example and would love to get it merged as well. Can you please rebase against latest main?
Closing this now that I merged #143 (which was a fork from this!). Thank you for the contribution @Nicba1010!