nwabap751 icon indicating copy to clipboard operation
nwabap751 copied to clipboard

Consider adding copy of *.rar files in DockerFile

Open sorenviggo opened this issue 7 years ago • 3 comments

Please consider a prerequisite step as suggested in https://github.com/nzamani/sap-nw-abap-trial-docker The step would be to create a local folder called 'sapdownloads', and then adding all .rar installation files to this. The DockerFile then should have this line added. COPY sapdownloads /tmp

Then no other manual steps would be needed.

sorenviggo avatar Oct 16 '18 13:10 sorenviggo

yeah, I havent really maintained this for a while, the one by @nzamani is good :)

larshp avatar Oct 16 '18 14:10 larshp

I have tested both, but actually find yours to be superior, due to the local '/tmp/install.sh' script you are creating, to perform the unrar locally in the container. But with very little effort, you could adopt 2 small enhancements from @nzamani, then yours would be perfect. If you add the prerequisite step with creating the folder, and adding below 2 lines in the DockerFile, then you can install the entire SAP system, by running only 3 commands in the cmd.

RUN mkdir /run/uuidd && chown uuidd /var/run/uuidd && /usr/sbin/uuidd
COPY sapdownloads /tmp

Brgds, Søren.

sorenviggo avatar Oct 17 '18 08:10 sorenviggo

Pull requests welcome 😄

larshp avatar Oct 17 '18 08:10 larshp