Lars Hvam

Results 1025 comments of Lars Hvam
trafficstars

https://webassembly.github.io/wabt/demo/wat2wasm/

as a consequence, the code must only contain unit tests, suggest moving integration tests to the layer that uses the application

note: the dangerous statements are in testclasses, which is a no-go IMHO do integration test outside of the normal tests

https://github.com/SAP/abap-file-formats-tools/pull/158#discussion_r946374394 ready low hanging, pull requests welcome

looks like some is used for internal logic ```abap TYPES: BEGIN OF ENUM enum_formatting_option STRUCTURE formatting_option, no_formatting VALUE IS INITIAL, camel_case VALUE 1, END OF ENUM enum_formatting_option STRUCTURE formatting_option, BEGIN...

was hoping not to downport ENUMs but guess I'll add that, work work 🚈

testcase, can be removed, out of scope? ```abap METHOD enum_element. * base type / base structure/ ohne (integer) TYPES: BEGIN OF ENUM category, general ##NEEDED, classic_badi ##NEEDED, END OF ENUM...

keep the internal logic as is, I implemented automatic downport of ENUMS to constants earlier today, ![image](https://user-images.githubusercontent.com/5888506/164451110-f5f7ed65-4940-4c84-944f-0e9851d8e8fb.png)

yea (but in this case we want to maintain the code in the high version/ENUM)