Lars Hvam

Results 1027 comments of Lars Hvam

class descriptions interface descriptions method descripiptions and more rule name = `shorttext_unsynchronized`

https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs

https://github.com/abaplint/abaplint/blob/main/packages/core/src/abap/types/class_definition.ts smaller example, ```abap CLASS zcl_oapi_graph DEFINITION. PUBLIC SECTION. METHODS add_edge IMPORTING is_edge TYPE ty_edge. PRIVATE SECTION. TYPES ty_edge TYPE string. ENDCLASS. CLASS zcl_oapi_graph IMPLEMENTATION. METHOD add_edge. RETURN. ENDMETHOD. ENDCLASS....

typically newlines are used to separate statements in ABAP, ie. its difficult to read if empty newlines are used to separate different parts of a chained statement

I'm not sure about this specific example, there is one UPDATE, so the subrc check should be moved inside the IF However, I think there are good examples for this...

lots more stuff can be done in this area small steps, implementing the `constant_class` rule will get some of the scaffolding in place, which can be used to make more...

and if the method/procedure only contains RETURN it is okay

see https://github.com/larshp/abapOpenChecks/blob/master/src/checks/zcl_aoc_check_27.clas.abap#L67