Lars Hvam

Results 1025 comments of Lars Hvam

1. 👍 I assume projects using pull requests, so it might not be the final version of the change 2. I worry about getting too many buttons, but guess it...

should treat generated as non existing, example in https://github.com/abapGit/abapGit/blob/main/src/objects/zcl_abapgit_object_view.clas.abap#L188 documented in https://github.com/abapGit/docs.abapgit.org/pull/13 / https://docs.abapgit.org/development/serializers.html

yea, and yea we cannot do it in the serializer itself, and it should not be centralized(see the example)

well, I dont think SAP consistently fills GENFLAG, plus not sure exactly what the semantics of the field is. If the object is generated by importing a different object in...

for a class, as far as I remember, the developer goes to edit a class in order to create or edit the texts? And the texts are deleted when the...

run the pretty printer on the full class source and add another commit to the branch

@frij-aws check the findings by the linter, https://github.com/abapGit/abapGit/pull/5575/checks?check_run_id=6509585553 we enforce static analysis, to get consistent code style, and the check must be green for the PR to be merged