Lars Hvam

good and bad in above depends on the development guidelines, so suggest it is a setting what the user prefers in case variables are prefixed, no need for the "me->"...

Robustness Security Architecture Compliance Performance Maintainability Bug Risk Clarity Compatibility Readability Complexity Duplication Style Unit Tests

yeah, its just difficult to categorize all under the best fitting category, guess we will just have to try

replace SELECT with value from TRDIR attribute? UPDATE: dont think using the TRDIR value will work, this logic was implemented to avoid reporting errors for SAP standard includes used in...

rfc function module RPY_PROGRAM_READ will do the trick? 

is bad, use classes

guess this is difficult, as PFCG objects are not in TADIR? or add to the object collector?

ie. nothing outside a specific root level package

https://blogs.sap.com/2018/09/06/remote-code-analysis-in-atc-how-to-write-an-atc-check/ describes something that might help solving this. I think the idea with central ATC breaks when checks get a bit more complicated like above, changes to development objects has...

Last section "ENSURING REMOTE ABILITY OF YOUR CHECK" of https://www.sap.com/documents/2018/09/905bfdab-1a7d-0010-87a3-c30de2ffd8ff.html is relevant it seems CL_ABAP_SOURCE_ID=>GET_DESTINATION is not present in 740